Re: [PATCH] gitweb: Extra columns in blame

From: Petr Baudis <pasky@suse.cz>
Date: May 18, 2007, 22:19 UTC
Message-ID: <20070518221916.GZ4489@pasky.or.cz>
In-Reply-To: <7vy7jl4zjm.fsf@assigned-by-dhcp.cox.net>

On Fri, May 18, 2007 at 11:01:01PM CEST, Junio C Hamano wrote:

Show 10 quoted lines

> Good job, except that I think you should also show the filename
> especially as you seem to run with -C (I haven't looked at the
> code yet, though).
> 
> E.g.
> 
> http://repo.or.cz/w/linux-2.6.git?a=blame_incremental;f=block/ll_rw_blk.c;h=6b5173ac81313d8adb5c1d7b521559f565bb209b;hb=347b4599dd6ffef27e18c227532d1ec66556000b
> 
> the first few hunks that came from 1da177e4 are from a different
> file, drivers/block/ll_rw_blk.c.

I don't use git-blame -C - I pass virtually no extra parameters to git-blame (except some output controlling). Passing -C to git-blame might be an interesting idea but the possible performance hit is a bit scary; when the dust settles and this gets merged or something, I can experiment with it a bit further...

(Also, I fear a bit about making it _too_ wide even with the extra columns; there should be reasonable portion of line still visible on usual resolutions with usual font sizes. Might be nice UI challenge.

Show 6 quoted lines

> Also the incremental thing using JavaScript does not seem to
> work for me incrementally for some reason, although if I wait
> long enough I get the fully blamed picture that seems to match
> nonincremental one.  While I am waiting, the browser goes silent
> and does not even let me switch to other tabs, so it is not all
> that useful to me in its current shape.

Strange, what browser are you using?

The trouble is, I'm not really very good at this kind of web development because I have access only to a rather narrow portion of the browser market - Firefox at Linux, at work also Galeon, Epiphany and Konqueror, and of course ELinks. I have theoretical access to MSIE at work but it's quite a hassle. With all browser I've tested it with, it worked without a problem, so I'm not sure how much will I be able to debug it (and I'm really bad at debugging javascript anyway).

-- 
				Petr "Pasky" Baudis
Stuff: http://pasky.or.cz/
Ever try. Ever fail. No matter. // Try again. Fail again. Fail better.
		-- Samuel Beckett