Re: [PATCH] gitweb: Add support for grep searches

From: Petr Baudis <pasky@suse.cz>
Date: May 18, 2007, 12:35 UTC
Message-ID: <20070518123538.GW4489@pasky.or.cz>
In-Reply-To: <f2k4d5$879$1@sea.gmane.org>

On Fri, May 18, 2007 at 01:58:28PM CEST, Jakub Narebski wrote:

> [Cc: Petr Baudis <pasky@suse.cz>, Junio C Hamano <junkio@cox.net>, 
>  git@vger.kernel.org]

Your MUA seems to have finally decided to go completely crazy or something. :-) Different mails go to us and the list.

Show 9 quoted lines

> Petr Baudis wrote:
> 
> > The 'grep' type of search greps the currently selected tree for given
> > regexp and shows the results in a fancy table with links into blob view.
> > The number of shown matches is limited to 1000 and the whole feature
> > can be turned off (grepping linux-2.6.git already makes repo.or.cz a bit
> > unhappy).
> 
> Ack, FWIW.

I want to implement the regexp checkbox.

> By the way, I wonder if we should make search context (view) sensitive.
> For example for 'history' view search would be limited to given pathspec,
> grep search in a 'tree' view would search given tree only.

I think it would be nice (if it's clearly visible that the results are filtered), but I'm probably not the one who is going to implement this. ;-)

> Additionally it would be nice to have links from search results page to
> have search match highlighted, like search results on GitWiki.

I'm sorry, I don't understand.

-- 
				Petr "Pasky" Baudis
Stuff: http://pasky.or.cz/
Ever try. Ever fail. No matter. // Try again. Fail again. Fail better.
		-- Samuel Beckett