git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Opinions on bug fix organisation

From
APAndy Parkins <andyparkins@gmail.com>
Date
May 16, 2007, 10:38 UTC
Message-ID
<200705161138.30134.andyparkins@gmail.com>
Hello,

This is not so much a question about git, but more about history organisation. I'm undecided on the best way to deal with bug fix history.

Imagine this situation:
 * -- * -- B -- * -- * -- *

"B" is a commit that introduced a feature and a bug, that bug is present forever more in history (which I think is good - history is history). I've pushed the repository to the rest of the developers in the meantime, so there is no editing "B" and doing some rebase magic.

Now, I want to make a commit that fixes that bug.  These are the options:
 * -- * -- B -- * -- * -- * -- F
 or
 * -- * -- B -- * -- * -- * -- M
            \                 /
             --------------- F

That is - just commit a fix or, commit the fix, "F", directly on "B" then merge that fix back to HEAD with "M".

I quite like option 2 because it records intent - i.e. "I wish I could have gone back and changed this revision, but I can't", but it makes a more complicated history.

What do people think?
Andy
-- 
Dr Andy Parkins, M Eng (hons), MIET
andyparkins@gmail.com
Next: Brian Gernhardt
Message 1 of 8 in “Opinions on bug fix organisation”
  1. Andy ParkinsMay 16, 2007
  2. Brian GernhardtMay 16, 2007
  3. Junio C HamanoMay 16, 2007
  4. Andy ParkinsMay 16, 2007
  5. Shawn O. PearceMay 16, 2007
  6. Johannes SixtMay 18, 2007
  7. Martin LanghoffMay 16, 2007
  8. Jan HudecMay 18, 2007

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.