Re: [StGIT PATCH] Don't use patches/<branch>/current

From: Yann Dirson <ydirson@altern.org>
Date: May 15, 2007, 21:08 UTC
Message-ID: <20070515210801.GO19253@nan92-1-81-57-214-146.fbx.proxad.net>
In-Reply-To: <b0943d9e0705150856n771cb696h6e8225a0bbd5d43d@mail.gmail.com>

On Tue, May 15, 2007 at 04:56:33PM +0100, Catalin Marinas wrote:

Show 13 quoted lines

> On 06/05/07, Karl Hasselström <kha@treskal.com> wrote:
> >The name of the current patch, if any, is always the last line of
> >patches/<branch>/applied (and there is no current patch if and only if
> >the "applied" file is empty). So use that instead, and stop having to
> >worry about keeping the redundant "current" file up-to-date.
> 
> I applied this patch. Could you also send me a patch for the
> bash-completion script as it uses this file?
> 
> I think the self.__current_file (same for the base file removed in a
> different patch) should still be available in the Series object and
> removed when deleting a branch, otherwise you get a "Series directory
> .. is not empty" exception.

Shouldn't we also migrate to new format as soon as we need to touch a data - in this case, whenever we push/pop ?

Or maybe declare a new "stgit stack format version" ? Currently we have "stg branch --convert", which switches between a "new" and an "old" format which noone probably uses any more. What about versionning the on-disk format, and possibly provide the "convert" functionnality back and forth between one format and the next, with formal documentation about which version works with which stack format ?

Best regards,

-- 
Yann.