git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH] Use $Id$ as the ident attribute keyword rather than $ident$ to be consistent with other VCSs

From
APAndy Parkins <andyparkins@gmail.com>
Date
May 14, 2007, 22:24 UTC
Message-ID
<200705142324.02929.andyparkins@gmail.com>
In-Reply-To
<7v646vo3pn.fsf@assigned-by-dhcp.cox.net>
On Monday 2007, May 14, Junio C Hamano wrote:
> My take when I did the $ident$ stuff on this issue was quite the
> opposite.  CVS "$Id$" means quite a different thing (pathname,

You're right, but I think it's intended as a unique identifier rather than that specific information. If that were wanted by a CVS/SVN user they would have used $Author$, $Rev$, $Date$, etc. $Id$ to me was just some way of identifying the file its in uniquely - the fact that git has a much better way of doing that is a bonus, and is exactly right for $Id$ IMHO.

> per-file revision number, date, and status) and it would not be
> right to overwrite it with $ident$ which does not record any of
> those "context sensitive" information.

It would be perfectly correct to overwrite it, as in the repository version none of that information is present, and even if it wasn't, as we've discussed at length, it's all meaningless in a git context anyway - the best thing that you could do for it _is_ overwrite it.

> I did not think other systems making that mistake was not an
> excuse for us to do so, but on the other hand, if the users of
> those other systems are happy to lose the information from CVS
> then perhaps the users do want $Id$.

As I said, there is no information in that field when we import from CVS/SVN - the repository versions are stored with the fields collapsed - so you are not overwriting anything, and therefore not losing information.

> Obviously I do not care much about this feature and I have not
> look at Andy's patch too deeply yet, but in any case I think the
> inverse conversion needs to be modified to match it, if it
> hasn't been done so.

I believe I did the inverse conversion as well. It's only rough, in the end I don't care much either way - I've already converted everything of mine to git so it affects me not at all. I offer it only as a suggestion for imports from other repositories.

Andy
-- 
Dr Andy Parkins, M Eng (hons), MIET
andyparkins@gmail.com
Previous: Junio C HamanoNext: Junio C Hamano
Message 7 of 14 in “Allow the ident attribute to include a length specifier”
  1. Allow the ident attribute to include a length specifierAndy Parkins, May 14, 2007
  2. Andy ParkinsMay 14, 2007
  3. Use $Id$ as the ident attribute keyword rather than $ident$ to be consistent with other VCSsAndy Parkins, May 14, 2007
  4. Johannes SixtMay 14, 2007
  5. Andy ParkinsMay 14, 2007
  6. Junio C HamanoMay 14, 2007
  7. Andy ParkinsMay 14, 2007
  8. Junio C HamanoMay 15, 2007
  9. Junio C HamanoMay 15, 2007
  10. Andy ParkinsMay 15, 2007
  11. Junio C HamanoMay 15, 2007
  12. Andy ParkinsMay 15, 2007
  13. Andy ParkinsMay 17, 2007
  14. Junio C HamanoMay 17, 2007

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.