Re: [StGIT PATCH v2] Document patch syntax.

From: Yann Dirson <ydirson@altern.org>
Date: May 13, 2007, 13:03 UTC
Message-ID: <20070513130354.GG16903@nan92-1-81-57-214-146.fbx.proxad.net>
In-Reply-To: <20070512204352.GE28039@diana.vm.bytemark.co.uk>

On Sat, May 12, 2007 at 10:43:52PM +0200, Karl Hasselström wrote:

Show 15 quoted lines

> On 2007-05-12 20:59:30 +0200, Yann Dirson wrote:
> 
> > Acked-by: Karl Hasselstr?m <kha@treskal.com>
> 
> Your mail headers say
> 
>   Content-Type:   text/plain; charset=utf-8
>   Content-Transfer-Encoding: QUOTED-PRINTABLE
> 
> but the body contains
> 
>   Acked-by: Karl Hasselstr=F6m <kha@treskal.com>
> 
> which is QP-encoded latin1, not utf8. (It's an illegal utf8 byte
> sequence, which is why it showed up as a question mark in my MUA.)

Right, I have seen that in gitk as well. My LC_CTYPE is "french", which is an iso8859-1 locale. I have not touched i18n.commitEncoding, which should then default to utf-8. Shouldn't a conversion to utf8 have happenned ? Things may be made different from standard git, since this commit was handled by stgit - we may have something to fix here :)

> s/refered/referred/. I missed this the first time -- sorry.

OK

Jeff wrote:

Show 5 quoted lines

>Karl's version is more correct (but your version might be used by many
>native speakers). The second half of the sentence is correct because
>'must' conjugates the same for singular and plural use; however, it
>might be more clear to say "...short name, each of which must be unique
>in the stack."

OK as well

Best regards,

-- 
Yann.