git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[PATCH] git-svn: don't drop the username from URLs when dcommit is run

From
EWEric Wong <normalperson@yhbt.net>
Date
May 13, 2007, 07:53 UTC
Message-ID
<20070513075316.GA1168@muzzle>
In-Reply-To
<20070512214035.GA18560@muzzle>
Eric Wong <normalperson@yhbt.net> wrote:
> Martin Eisenhardt <list-receive@mneisen.org> wrote:
> 
> Thanks for the bug report.  I haven't tested the patch below, so
> let me know if it works:
Junio: I've confirmed this patch works, please apply.  Thanks.
>From 58af622c222514dc3da938ce6309e1ac927a9574 Mon Sep 17 00:00:00 2001
From: Eric Wong <normalperson@yhbt.net>
Date: Sat, 12 May 2007 14:36:20 -0700
Subject: [PATCH] git-svn: don't drop the username from URLs when dcommit is run
We no longer store usernames in URLs stored in git-svn-id lines
for dcommit, so we shouldn't rely on those URLs when connecting
to the remote repository to commit.
---
 git-svn.perl |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/git-svn.perl b/git-svn.perl
index 3c4f490..d74e6d3 100755
--- a/git-svn.perl
+++ b/git-svn.perl
@@ -393,7 +393,7 @@ sub cmd_dcommit {
 		} else {
 			my %ed_opts = ( r => $last_rev,
 			                log => get_commit_entry($d)->{log},
-			                ra => Git::SVN::Ra->new($url),
+			                ra => Git::SVN::Ra->new($gs->full_url),
 			                tree_a => "$d~1",
 			                tree_b => $d,
 			                editor_cb => sub {
-- 
Eric Wong
Previous: Eric WongNext: Martin Eisenhardt
Message 3 of 4 in “Possible bug in git-svn”
  1. Martin EisenhardtMay 12, 2007
  2. Eric WongMay 12, 2007
  3. git-svn: don't drop the username from URLs when dcommit is runEric Wong, May 13, 2007
  4. Martin EisenhardtMay 13, 2007

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.