Re: [PATCH] remove unnecessary loop

From: Jan Hudec <bulb@ucw.cz>
Date: May 8, 2007, 09:39 UTC
Message-ID: <20070508093902.GB9007@efreet.light.src>
In-Reply-To: <4640015F.1080407@gmail.com>

On Tue, May 08, 2007 at 12:49:35 +0800, Liu Yubao wrote:

Show 13 quoted lines

> +#ifdef __CYGWIN__
> +		/*
> +		 * On cygwin, lstat("hello", &st) returns 0 when
> +		 * "hello.exe" exists, so test with open() again.
> +		 */
> +		if (lstat(match, &st) && -1 != (fd = open(match, O_RDONLY))) {
> +			struct dir_entry *ent;
> +			close(fd);
> +#else
>  		if (!lstat(match, &st)) {
>  			struct dir_entry *ent;
> -
> +#endif

You seem to have reversed the sense of the test.

-- 
						 Jan 'Bulb' Hudec <bulb@ucw.cz>