[EGIT PATCH 02/10] Recursion and update of all elements regardless of need.
- From
Robin Rosenberg <robin.rosenberg@dewire.com>
- Date
- May 7, 2007, 21:29 UTC
- Message-ID
- <20070507212919.21546.75269.stgit@lathund.dewire.com>
- In-Reply-To
- <20070507212636.21546.29280.stgit@lathund.dewire.com>
When selecting an element in the history view viewer.updateElement is called for every element recursively. If the number of elements is very largs this results in a stack overflow. This only happens with Eclipse 3.3 M7 and not M6.
Is it thig bug? https://bugs.eclipse.org/bugs/show_bug.cgi?id=149642
Signed-off-by: Robin Rosenberg <robin.rosenberg@dewire.com> ---
.../src/org/spearce/egit/ui/GitHistoryPage.java | 3 +++ 1 files changed, 3 insertions(+), 0 deletions(-)
diff --git a/org.spearce.egit.ui/src/org/spearce/egit/ui/GitHistoryPage.java b/org.spearce.egit.ui/src/org/spearce/egit/ui/GitHistoryPage.java index 7bc947b..8be23ec 100644 --- a/org.spearce.egit.ui/src/org/spearce/egit/ui/GitHistoryPage.java +++ b/org.spearce.egit.ui/src/org/spearce/egit/ui/GitHistoryPage.java @@ -281,6 +281,8 @@ public class GitHistoryPage extends HistoryPage implements IAdaptable, viewer = new TreeViewer(tree, SWT.VIRTUAL | SWT.FULL_SELECTION); + viewer.setUseHashlookup(true); + createColumns(); viewer.setLabelProvider(new GitHistoryLabelProvider()); @@ -354,6 +356,7 @@ public class GitHistoryPage extends HistoryPage implements IAdaptable, } public void updateElement(Object parent, int index) { + System.out.println("updateElement("+parent+","+index); viewer.replace(parent, index, fileRevisions[index]); } }