Re: [PATCH] git-config: read remote config files over HTTP

From: Sven Verdoolaege <skimo@kotnet.org>
Date: May 6, 2007, 13:53 UTC
Message-ID: <20070506135306.GB942MdfPADPa@greensroom.kotnet.org>
In-Reply-To: <7virb6fnkv.fsf@assigned-by-dhcp.cox.net>

On Sat, May 05, 2007 at 11:55:28PM -0700, Junio C Hamano wrote:

Show 12 quoted lines

> Sven Verdoolaege <skimo@liacs.nl> writes:
> > +static int config_from_http(config_fn_t fn, char *dest)
> > +{
> > +	static char *config_temp = "config.temp";
> > +	if (git_http_fetch_config(dest, config_temp))
> > +		return 1;
> > +	git_config_from_file(fn, config_temp);
> > +	unlink(config_temp);
> > +	return 0;
> > +}
> 
> Not mkstemp()?

I more or less copy-pasted the way "index" is handled now. I'll use mkstemp in the next round.

Show 5 quoted lines

> > +	if (!prefixcmp(dest, "http://"))
> > +		return config_from_http(fn, dest);
> > +
> 
> Shouldn't this also work for other protocols we handle via curl?

I don't think I copied the required setup for https, but ftp should work.

Show 6 quoted lines

> > +#ifdef USE_CURL_MULTI
> > +void (*fill_active_slots)(void) = NULL;
> > +#endif
> > +
> 
> I wonder if we could lose USE_CURL_MULTI around this one,...

I wondered about that too, but I wanted to make my changes as minimal as possible. I'll drop the #ifdef in the next round.

skimo