git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[PATCH 1/2] Cleanup variable names in pick.

From
Yann Dirson <ydirson@altern.org>
Date
May 5, 2007, 14:00 UTC
Message-ID
<20070505140023.5194.8083.stgit@gandelf.nowhere.earth>
In-Reply-To
<20070505135830.5194.90861.stgit@gandelf.nowhere.earth>

I'm going to need patch objects there, so avoid using variable "patch" to store only a patchname.

Signed-off-by: Yann Dirson <ydirson@altern.org>
---
 stgit/commands/pick.py |   12 ++++++------
 1 files changed, 6 insertions(+), 6 deletions(-)
diff --git a/stgit/commands/pick.py b/stgit/commands/pick.py
index edd614d..4eb79a3 100644
--- a/stgit/commands/pick.py
+++ b/stgit/commands/pick.py
@@ -71,11 +71,11 @@ def func(parser, options, args):
     else:
         patch_branch = commit_str.split('@')
         if options.name:
-            patch = options.name
+            patchname = options.name
         elif len(patch_branch) == 2:
-            patch = patch_branch[0]
+            patchname = patch_branch[0]
         else:
-            patch = make_patch_name(commit.get_log(), crt_series.patch_exists)
+            patchname = make_patch_name(commit.get_log(), crt_series.patch_exists)
 
     if options.parent:
         parent = git_id(options.parent)
@@ -118,17 +118,17 @@ def func(parser, options, args):
         print 'Importing commit %s...' % commit_id,
         sys.stdout.flush()
 
-        crt_series.new_patch(patch, message = message, can_edit = False,
+        crt_series.new_patch(patchname, message = message, can_edit = False,
                              unapplied = True, bottom = bottom, top = top,
                              author_name = author_name,
                              author_email = author_email,
                              author_date = author_date)
         if not options.unapplied:
-            modified = crt_series.push_patch(patch)
+            modified = crt_series.push_patch(patchname)
         else:
             modified = False
 
-        if crt_series.empty_patch(patch):
+        if crt_series.empty_patch(patchname):
             print 'done (empty patch)'
         elif modified:
             print 'done (modified)'
Previous: Yann DirsonNext: Yann Dirson
Message 2 of 3 in “Improving patchlogs”
  1. 0/2 Improving patchlogsYann Dirson, May 5, 2007
  2. 1/2 Cleanup variable names in pick.Yann Dirson, May 5, 2007
  3. 2/2 Copy patchlogs when cloning a stack or picking a patch.Yann Dirson, May 5, 2007

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.