Re: [PATCH] git-svn: Add 'find-rev' command

From: Eric Wong <normalperson@yhbt.net>
Date: Apr 29, 2007, 22:25 UTC
Message-ID: <20070429222544.GB1800@untitled>
In-Reply-To: <31790C65-1FE6-4BD4-B8D3-B285F0F0422A@apple.com>

Adam Roben <aroben@apple.com> wrote:

Show 7 quoted lines

> On Apr 29, 2007, at 11:35 AM, Eric Wong wrote:
> 
> >Also, if you have time, can you get this (and 'log') to understand
> >revision numbers even if they're not from the working HEAD?  Thanks.
> 
>    Won't the following code accomplish that for find-rev? Perhaps I  
> misunderstand you.

working_head_info() only calls rev-list for a given head.

You should probably iterate through (like fetch_all does) each remote and do rev_db_get via the Git::SVN object.

Show 9 quoted lines

> >>+sub cmd_find_rev {
> >>+	my $revision_or_hash = shift;
> >>+	my $result;
> >>+	if ($revision_or_hash =~ /^r\d+$/) {
> >>+		my $head = shift;
> >>+		$head ||= 'HEAD';
> >>+		my @refs;
> >>+		my (undef, undef, undef, $gs) = working_head_info($head, 
> >>\@refs);

-- 
Eric Wong