Re: [PATCH 3/7] gitweb: support filename prefix in git_patchset_body/git_difftree_body

From: Martin Koegler <mkoegler@auto.tuwien.ac.at>
Date: Apr 28, 2007, 08:22 UTC
Message-ID: <20070428082233.GA19578@auto.tuwien.ac.at>
In-Reply-To: <200704271255.24200.jnareb@gmail.com>

On Fri, Apr 27, 2007 at 12:55:22PM +0200, Jakub Narebski wrote:

Show 11 quoted lines

> On Sunday, 15 April 2007, Martin Koegler wrote:
> > git_treediff supports comparing subdirectories. As the output of
> > git-difftree is missing the path to the compared directories,
> > the links in the output would be wrong.
> 
> You mean that git-diff-tree output for diff between two non-toplevel
> trees lacks the path to compared tree, e.g.
>   $ git diff-tree <commit1>:<path1> <commit2>:<path2>
> lacks <path1> prefix in the from part, and <path2> prefix in to part,
> and the goal is to add those missing prefixes in the links, without
> changing the visible output of git_patchset_body/git_difftree_body.

Yes, as I don't want to rewrite the raw view.

Show 7 quoted lines

> > The patch adds two new parameters to add the missing path prefix.
> 
> ...and makes use of them while generating links.
> 
> Although I'm not sure if it wouldn't be better to put e.g.
> $prefix_from.$diff{'file'} in $diff{'file_from_url'} or something
> like that.

Would this really simplify the code?

Figuring out, what is stored in $diff and how its elements are used, requries more time. Adding a prefix is easier to understand.

> Looks nice, although I think this patch is needed only when we have
> "treediff" (and "treediff_plain") views, i.e. when we are able to
> compare not only top level trees (like in "commitdiff" view),
> or individual files (in "blobdiff" view), but also arbitrary trees.

My git_treediff patch supports this. My JavaScript prototyp can be used to select such a comparison.

mfg Martin Kögler