Re: [PATCH] gitweb: Add support for grep searches

From: Petr Baudis <pasky@suse.cz>
Date: Apr 27, 2007, 04:21 UTC
Message-ID: <20070427042111.GV4489@pasky.or.cz>
In-Reply-To: <alpine.LFD.0.98.0704262055270.9964@woody.linux-foundation.org>

On Fri, Apr 27, 2007 at 05:59:29AM CEST, Linus Torvalds wrote:

Show 13 quoted lines

> 
> 
> On Fri, 27 Apr 2007, Petr Baudis wrote:
> > 
> > 	http://repo.or.cz/w?p=git.git&a=search&h=HEAD&st=grep&s=hate%5B%5Ev%5D
> 
> That looks bogus. It doesn't find
> 
>  - Documentation/git-cvsimport.txt:
> 
> 	git-cvsimport - Salvage your data out of another SCM people love to hate
> 
> Why?

Because it doesn't accept hate$, it should be like

	http://repo.or.cz/w?p=git.git&a=search&h=HEAD&st=grep&s=hate%28%5B%5Ev%5D%7C%24%29

or even better

	http://repo.or.cz/w?p=git.git&a=search&h=HEAD&st=grep&s=hate%5Cb

but in order to be able to use the regexps without breaking your backslash key and eyes, I think it's somewhat saner to accept extended regexps instead of basic regexps; YMMV, I'll let Junio or the list decide which way is better.

-- 
				Petr "Pasky" Baudis
Stuff: http://pasky.or.cz/
Ever try. Ever fail. No matter. // Try again. Fail again. Fail better.
		-- Samuel Beckett