Re: [PATCH 4/4] Add 'filter' attribute and external filter driver definition.

From: Shawn O. Pearce <spearce@spearce.org>
Date: Apr 22, 2007, 03:00 UTC
Message-ID: <20070422030038.GF17480@spearce.org>
In-Reply-To: <7vbqhhrw7m.fsf@assigned-by-dhcp.cox.net>

Junio C Hamano <junkio@cox.net> wrote:

> Well, I did not like start_command() that wanted to always
> perform the full exec of something else for its inflexibility,
> and this piles a specific hack on top of it...  Why not a
> callback with void * pointer?

Well, that's because its always used to execute some external program. And some operating system designers once upon a time thought that was the only way anyone would ever need to start a new parallel thread of execution. ;-)

But why do you want a callback here in start_command() given that all you are doing is running a filter command anyway? Is that so you could start a "thread" to handle the stdin pipe?

-- 
Shawn.