Re: Segmentation fault in git-svn

From: Eric Wong <normalperson@yhbt.net>
Date: Apr 17, 2007, 09:55 UTC
Message-ID: <20070417095509.GA24800@muzzle>
In-Reply-To: <20070417093743.GA9222@muzzle>

This disables some pool allocations, forcing it to use the global one.

Other than that, my eyes are barely open and my brain is having trouble functioning at this time of morning.

diff --git a/git-svn.perl b/git-svn.perl
index ac44f60..cff81f7 100755
--- a/git-svn.perl
+++ b/git-svn.perl
@@ -2883,7 +2883,7 @@ BEGIN {
 			wantarray ? \@ret : \$ret[0]; }\n";
 	}
 	$e .= "\n1;";
-	eval $e or die $@;
+	# eval $e or die $@;
 }
 
 sub new {
@@ -2925,10 +2925,10 @@ sub DESTROY {
 
 sub get_log {
 	my ($self, @args) = @_;
-	my $pool = SVN::Pool->new;
+	# my $pool = SVN::Pool->new;
 	splice(@args, 3, 1) if ($SVN::Core::VERSION le '1.2.0');
-	my $ret = $self->SUPER::get_log(@args, $pool);
-	$pool->clear;
+	my $ret = $self->SUPER::get_log(@args);
+	# $pool->clear;
 	$ret;
 }

-- 
Eric Wong