Re: [PATCH 2/2] git-bisect: allow bisecting with only one bad commit.

From: Christian Couder <chriscool@tuxfamily.org>
Date: Apr 17, 2007, 05:07 UTC
Message-ID: <200704170707.10938.chriscool@tuxfamily.org>
In-Reply-To: <7v7isqkoa3.fsf_-_@assigned-by-dhcp.cox.net>

Hi Junio,

You wrote:

[...]

Show 16 quoted lines

> -test_expect_success 'bisect does not start with only one bad' '
> +test_expect_success 'bisect starts with only one bad' '
>  	git bisect reset &&
>  	git bisect start &&
> -	git bisect bad $HASH4 || return 1
> -
> -	if git bisect next
> -	then
> -		echo Oops, should have failed.
> -		false
> -	else
> -		:
> -	fi
> +	git bisect bad $HASH4 &&
> +	git bisect next
>  '

Ok, this is the purpose of your patch to make the above work.

Show 5 quoted lines

> -test_expect_success 'bisect does not start with only one good' '
> +test_expect_success 'bisect starts with only one good' '
>  	git bisect reset &&
>  	git bisect start &&
>  	git bisect good $HASH1 || return 1

But I don't understand the need to change the above comment when the test code for starting with one good commit is not changed.

Thanks, Christian.