Re: [PATCH] entry.c: Use strerror() to print error info when possible

From: Alex Riesen <raa.lkml@gmail.com>
Date: Apr 15, 2007, 23:00 UTC
Message-ID: <20070415230020.GC4417@steel.home>
In-Reply-To: <20070415185619.3fa90f3a@gnut>

Luiz Fernando N. Capitulino, Sun, Apr 15, 2007 23:56:19 +0200:

Show 17 quoted lines

> 
> Signed-off-by: Luiz Fernando N. Capitulino <lcapitulino@mandriva.com.br>
> ---
>  entry.c |   11 ++++++-----
>  1 files changed, 6 insertions(+), 5 deletions(-)
> 
> diff --git a/entry.c b/entry.c
> index d72f811..c36c09d 100644
> --- a/entry.c
> +++ b/entry.c
> @@ -19,7 +19,8 @@ static void create_directories(const char *path, struct checkout *state)
>  				if (!stat(buf, &st) && S_ISDIR(st.st_mode))
>  					continue; /* ok */
>  			}
> -			die("cannot create directory at %s", buf);
> +			die("cannot create directory at %s (%s)", buf,
> +			    strerror(errno));

This errno is not very useful, as it may come from the stat above, and you provided no way to figure out what was the syscall (the mkdir or the stat) which failed. Also, the errnos of unlink or mkdir just above the stat are just lost.

It is not worse than before, but not very much better either, and probably confusing. I suggest you just leave this one as it is.