Re: git-quiltimport complaining yet still working

From: Greg KH <greg@kroah.com>
Date: Apr 14, 2007, 03:57 UTC
Message-ID: <20070414035726.GA6488@kroah.com>
In-Reply-To: <Pine.LNX.4.64.0704131431040.28042@woody.linux-foundation.org>

On Fri, Apr 13, 2007 at 02:34:18PM -0700, Linus Torvalds wrote:

Show 21 quoted lines

> 
> 
> On Fri, 13 Apr 2007, Greg KH wrote:
> >
> > In git 1.5.1 the quiltimport function started complaining in a new way:
> > 
> > 	libata-clear-tf-before-doing-request-sense.patch
> > 	Patch is empty.  Was is split wrong?
> > 	/usr/bin/git-quiltimport: line 78: stop_here: command not found
> 
> This is an *old* bug. It got fixed once already. Did it get re-introduced?
> 
> Ahh - somebody copied the bug from git-applymbox
> 
> > Any hints?  Or is it time to start bisecting?
> 
> This should fix it.
> 
> There were two bugs: "stop_here" doesn't exist, but the bug that causes 
> this code to trigger in the *first* place is the wrong use of "$dotest". 
> It should be ".dotest"

Thanks, that seems to do the trick for me.

greg k-h