git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: git-mailinfo munges the patch?

From
DZDon Zickus <dzickus@redhat.com>
Date
Mar 29, 2007, 21:52 UTC
Message-ID
<20070329215248.GG11029@redhat.com>
In-Reply-To
<Pine.LNX.4.64.0703291417250.6730@woody.linux-foundation.org>
On Thu, Mar 29, 2007 at 02:19:26PM -0700, Linus Torvalds wrote:
Show 14 quoted lines
> 
> 
> On Thu, 29 Mar 2007, Don Zickus wrote:
> > 
> > Ok.  I see what you are saying with the old code.  Sorry about that.  Do
> > you have a sample file that I can play with to test my fix?
> 
> On that note - here's an unrelated simple case that the old mailinfo got 
> right, but the new one seems to screw up: multiple Subject: lines.
> 
> The old one would make later Subject: lines override the earlier ones, and 
> I depended on that when I fix up peoples emails to me manually (you 
> wouldn't believe how bad explanations or subject lines people use for 
> perfectly good patches ;)

I see what happened. The old code allowed rewriting of the mail headers but blocked rewriting of the inbody headers. For some reason I thought it was by accident that the mail headers were allow to be rewritten. Oops. :(

I wrote the code to have both header types block rewriting. I'll change that.

Cheers, Don

Previous: Linus TorvaldsNext: Junio C Hamano
Message 4 of 6 in “git-mailinfo munges the patch?”
  1. Junio C HamanoMar 29, 2007
  2. Don ZickusMar 29, 2007
  3. Linus TorvaldsMar 29, 2007
  4. Don ZickusMar 29, 2007
  5. Junio C HamanoMar 29, 2007
  6. Don ZickusMar 29, 2007

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.