Re: [PATCH] pager: default to LESS=FRX not LESS=FRSX

From: Eygene Ryabinkin <rea-git@codelabs.ru>
Date: Mar 26, 2007, 10:08 UTC
Message-ID: <20070326100857.GW14837@codelabs.ru>
In-Reply-To: <7v8xdkxukt.fsf@assigned-by-dhcp.cox.net>

Junio,

Mon, Mar 26, 2007 at 01:44:34AM -0700, Junio C Hamano wrote:

Show 10 quoted lines

> > Junio C Hamano <junkio@cox.net> wrote:
> >> Eygene Ryabinkin <rea-git@codelabs.ru> writes:
> >> 
> >> > Remove unnecessary '-S' option that enabled less to chop long lines.
> >> > It used to provide some confusion at least for the 'git diff':
> >> > "Where are my long lines? Are they missed from the patch?".
> >> 
> >> It is not "unnecessary", but only "what _you_ are not used to".
> >> As this breaks expectentions of people already familiar with
> >> what git does by default, I cannot take this patch.

OK, no problem.

Show 7 quoted lines

> > Hear hear.  I completely agree with Junio.  I (and a number of
> > other users that I work with) expect this behevaior by default.
> 
> Two tips.
> 
>  (1) Learn to use left/right arrow keys under "less -S" if you
>      have occasional lines that are too long.

I do not like the left/right keys: it is wery hard to get the right typing speed if we're using the arrow keys. But it is just my habit since I learned to 10 fingers typing.

>  (2) Do not have too many too long lines to begin with.  If you
>      cannot comfortably read your code with "less -S", your
>      nesting is too deep to be understood with or without line
>      folding.

Yes, yes, "if you need more than 4 levels of identation then your code is probably in a bad shape". I know it. But the problem was that I noticed this behaviour when I was patching the Git sources and there were some removed lines that were long enough not to fit to the screen with the addition of the '- ' diff tags.

-- 
Eygene