git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[PATCH] use xstrdup please

From
Shawn O. Pearce <spearce@spearce.org>
Date
Mar 16, 2007, 01:02 UTC
Message-ID
<20070316010251.GA31023@spearce.org>

We generally prefer xstrdup to just plain strdup. Make it so.

Signed-off-by: Shawn O. Pearce <spearce@spearce.org>
---
 config.c |    4 ++--
 1 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/config.c b/config.c
index a3c7b77..d537311 100644
--- a/config.c
+++ b/config.c
@@ -351,12 +351,12 @@ int git_default_config(const char *var, const char *value)
 	}
 
 	if (!strcmp(var, "i18n.commitencoding")) {
-		git_commit_encoding = strdup(value);
+		git_commit_encoding = xstrdup(value);
 		return 0;
 	}
 
 	if (!strcmp(var, "i18n.logoutputencoding")) {
-		git_log_output_encoding = strdup(value);
+		git_log_output_encoding = xstrdup(value);
 		return 0;
 	}
 
-- 
1.5.0.4.1009.gd3da
Message 1 of 1 in “use xstrdup please”
  1. use xstrdup pleaseShawn O. Pearce, Mar 16, 2007

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.