git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[PATCH 02/10] Fix diagnostic messages on patch deletion and simplify others.

From
Yann Dirson <ydirson@altern.org>
Date
Mar 15, 2007, 00:26 UTC
Message-ID
<20070315002639.9094.82423.stgit@gandelf.nowhere.earth>
In-Reply-To
<20070315001808.9094.68529.stgit@gandelf.nowhere.earth>

Also make use standard os.removedirs(), allowing for the same simplification.

Signed-off-by: Yann Dirson <ydirson@altern.org>
---
 stgit/stack.py |   15 ++++++++-------
 1 files changed, 8 insertions(+), 7 deletions(-)
diff --git a/stgit/stack.py b/stgit/stack.py
index 8a63102..8fdaf2c 100644
--- a/stgit/stack.py
+++ b/stgit/stack.py
@@ -571,7 +571,7 @@ class Series(StgitObject):
                 os.rmdir(self.__patch_dir)
                 print 'done'
             else:
-                print 'Patch directory %s is not empty.' % self.__name
+                print 'Patch directory %s is not empty.' % self.__patch_dir
 
             self.__patch_dir = self._dir()
 
@@ -678,18 +678,19 @@ class Series(StgitObject):
                 os.remove(self.__descr_file)
             if os.path.exists(self._dir()+'/orig-base'):
                 os.remove(self._dir()+'/orig-base')
+
             if not os.listdir(self.__patch_dir):
                 os.rmdir(self.__patch_dir)
             else:
-                print 'Patch directory %s is not empty.' % self.__name
+                print 'Patch directory %s is not empty.' % self.__patch_dir
+
             if not os.listdir(self._dir()):
-                remove_dirs(os.path.join(self.__base_dir, 'patches'),
-                            self.__name)
+                os.removedirs(self._dir())
             else:
-                print 'Series directory %s is not empty.' % self.__name
+                raise StackException, 'Series directory %s is not empty.' % self._dir()
+
             if not os.listdir(self.__refs_dir):
-                remove_dirs(os.path.join(self.__base_dir, 'refs', 'patches'),
-                            self.__name)
+                os.removedirs(self.__refs_dir)
             else:
                 print 'Refs directory %s is not empty.' % self.__refs_dir
 
Previous: Yann DirsonNext: Yann Dirson
Message 3 of 11 in “Various fixes and improvements”
  1. 00/10 Various fixes and improvementsYann Dirson, Mar 15, 2007
  2. 01/10 Fix stack deletion when orig-base is present.Yann Dirson, Mar 15, 2007
  3. 02/10 Fix diagnostic messages on patch deletion and simplify others.Yann Dirson, Mar 15, 2007
  4. 03/10 Make use exception raised by removedirs.Yann Dirson, Mar 15, 2007
  5. 04/10 Drop utils.remove_dirs() in favor of os.removedirs().Yann Dirson, Mar 15, 2007
  6. 05/10 Copy parentbranch setting on 'stg branch --clone'.Yann Dirson, Mar 15, 2007
  7. 06/10 Remove debugging output from contrib/stg-sinkYann Dirson, Mar 15, 2007
  8. 07/10 Stop recording branch.*.remote to '.' for local parents.Yann Dirson, Mar 15, 2007
  9. 08/10 Add a script to quickly run an interactive test session.Yann Dirson, Mar 15, 2007
  10. 09/10 Add support for unsetting config vars.Yann Dirson, Mar 15, 2007
  11. 10/10 Cleanup parent information on stgit branch deletion.Yann Dirson, Mar 15, 2007

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.