Re: [PATCH] git-init: set up GIT_DIR/workdir if GIT_WORK_DIR is set

From: Matthias Lederhofer <matled@gmx.net>
Date: Mar 12, 2007, 18:08 UTC
Message-ID: <20070312180837.GA22701@moooo.ath.cx>
In-Reply-To: <7vabyitlld.fsf@assigned-by-dhcp.cox.net>

Junio C Hamano <junkio@cox.net> wrote:

Show 8 quoted lines

> Matthias Lederhofer <matled@gmx.net> writes:
> 
> > ... because
> > $GIT_WORK_DIR is normally interpreted as relative path to the current
> > working directory and not relative to $GIT_DIR.
> 
> Well, it could be that _that_ handling of the environment
> variable is what needs to be fixed.

You're right,  this seems to be much better.

I just thought that GIT_WORK_DIR should be relative to the current working directory because it's more intuitive, e.g.

    $ git --git-dir=/path/to/repo.git --work-dir=../.. add a

where ../.. matches the path to the toplevel working directory from cwd. But this definitely is annoying when changing directories.

I'll go and fix this. Do you prefer an amended patch or just a patch on top?