Re: [PATCH 1/8] Switch to run_command_v_opt in revert
- From
Shawn O. Pearce <spearce@spearce.org>
- Date
- Mar 11, 2007, 01:46 UTC
- Message-ID
- <20070311014640.GB10343@spearce.org>
- In-Reply-To
- <Pine.LNX.4.63.0703101755090.22628@wbgn013.biozentrum.uni-wuerzburg.de>
Johannes Schindelin <Johannes.Schindelin@gmx.de> wrote:
Show 7 quoted lines
> On Sat, 10 Mar 2007, Shawn O. Pearce wrote: > > Another change by me is removing the va_list variants of run_command, > > one of which is used by builtin-revert.c. To avoid compile errors > > I'm refactoring builtin-revert to use the char** variant instead, > > as that variant is staying. > > I did not realize that -revert and -cherry-pick would be the only users...
I didn't realize how little those functions were used either until I started poking around in there. I'm actually shocked that your builtin-revert rewrite was the only one using it. ;-)
-- Shawn.