git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH 6/9] Use uint32_t for pack-objects counters.

From
Shawn O. Pearce <spearce@spearce.org>
Date
Mar 7, 2007, 20:37 UTC
Message-ID
<20070307203721.GD27922@spearce.org>
In-Reply-To
<7v1wk0g9mp.fsf@assigned-by-dhcp.cox.net>
Junio C Hamano <junkio@cox.net> wrote:
Show 7 quoted lines
> I may not be reading the patch correctly, but doesn't this make
> find_deltas() logic to scan the list backwards?  We sort the
> list by type and size before we enter this, so that we scan from
> bigger to smaller, because we prefer to leave biggest as a base
> and represent smaller ones as deltas (removing deltas do not
> have to record preimage and tend to be much smaller than adding
> deltas).  I suspect this change may affect that optimization.

Its always scanned backwards. I've read the patch like 8 times now (and I just reread the part you quoted). The patch implements the same backwards scan that has always been there. Linus put it backwards for the exact reason you state; bigger objects are near the end of the array (see type_size_sort).

-- 
Shawn.
Previous: Junio C HamanoNext: Junio C Hamano
Message 3 of 4 in “Use uint32_t for pack-objects counters.”
  1. 6/9 Use uint32_t for pack-objects counters.Shawn O. Pearce, Mar 7, 2007
  2. Junio C HamanoMar 7, 2007
  3. Shawn O. PearceMar 7, 2007
  4. Junio C HamanoMar 7, 2007

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.