Re: [PATCH] Support of "make -s": do not output anything of the build itself

From: Shawn O. Pearce <spearce@spearce.org>
Date: Mar 6, 2007, 23:29 UTC
Message-ID: <20070306232927.GB25785@spearce.org>
In-Reply-To: <81b0412b0703061514m2f2b3237yd1192dd651a1109e@mail.gmail.com>

Alex Riesen <raa.lkml@gmail.com> wrote:

Show 5 quoted lines

> Signed-off-by: Alex Riesen <raa.lkml@gmail.com>
> ---
> Makefile         |   10 +++++++---
> git-gui/Makefile |    5 -----
> 2 files changed, 7 insertions(+), 8 deletions(-)

Nack. You need to split any git-gui changes into their own patch so that I can apply them to the git-gui repository directly. Junio then merges that into git.git.

> +QUIET_SUBDIR0  = $(MAKE) -C # space to separate -C and subdir
> +QUIET_SUBDIR1  =
> +
> +ifneq ($(findstring $(MAKEFLAGS),s),s)

This is a good idea.

Show 13 quoted lines

>  ifndef V
>  	QUIET_CC       = @echo '   ' CC $@;
>  	QUIET_AR       = @echo '   ' AR $@;
> @@ -615,9 +620,8 @@ ifndef V
>  			 $(MAKE) --no-print-directory -C $$subdir
>  	export V
>  	export QUIET_GEN
> -else
> -	QUIET_SUBDIR0  = $(MAKE) -C
> -	QUIET_SUBDIR1  =
> +	export QUIET_BUILT_IN
> +endif
>  endif

Show 6 quoted lines

> diff --git a/git-gui/Makefile b/git-gui/Makefile
> -ifndef V
> -	QUIET_GEN      = @echo '   ' GEN $@;
> -	QUIET_BUILT_IN = @echo '   ' BUILTIN $@;
> -endif
> -

git-gui can be built on its own, outside of git.git's make system. I need the ifneq(...-s...) thing above also here, around the existing ifndef.

Want to rework the patch as two?  ;-)

-- 
Shawn.