Re: [PATCH 5/7] Try to do things in the right order
- From
- Xavier Maillard <zedek@gnu.org>
- Date
- Mar 5, 2007, 07:27 UTC
- Message-ID
- <200703050727.l257Rv0k007635@localhost.localdomain>
- In-Reply-To
- <87ps7qty5l.fsf@wine.dyndns.org>
From: Alexandre Julliard <julliard@winehq.org>
Xavier Maillard <zedek@gnu.org> writes:
> @@ -35,8 +36,14 @@ > (require 'vc) > (require 'cl)) > > -;; Add it automatically > -(add-to-list 'vc-handled-backends 'GIT) > +;; HACK: clear up the cache to force vc-call to check again and > +;; discover new functions when we reload this file. > +(put 'GIT 'vc-functions nil) > + > +;; Add it automatically when loading vc > +;; FIXME: should be directly put into vc.el > +(eval-after-load "vc" > + '(add-to-list 'vc-handled-backends 'GIT))
That's ugly. Simply recommending that users set vc-handled-backends in their .emacs is easier and cleaner, I still don't see why you want to change it.
I'd rather want to just require or load vc-git (and that should not be the way to go too since it should be automatically handled by vc.el when vc-git will become part of GNU Emacs ).
By the way, do you plan to ask for inclusion into emacs ?
That's just a matter of taste, nothing more.
-- Xavier