git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [patch] KVM: T60 resume fix

From
AMAndrew Morton <akpm@linux-foundation.org>
Date
Mar 3, 2007, 11:57 UTC
Message-ID
<20070303035742.72eed3df.akpm@linux-foundation.org>
In-Reply-To
<45E93012.4000100@qumranet.com>
On Sat, 03 Mar 2007 10:21:38 +0200 Avi Kivity <avi@qumranet.com> wrote:
Show 39 quoted lines
> Ingo Molnar wrote:
> > Subject: [patch] KVM: T60 resume fix
> > From: Ingo Molnar <mingo@elte.hu>
> >
> > my T60 laptop does not resume correctly due to KVM attempting to send an 
> > IPI to a CPU that might be down (or not up yet). (Doing so also triggers 
> > the send_IPI_mask_bitmask() warning in arch/i386/kernel/smp.c, line 
> > 732.)
> >
> > with this fix applied my laptop does not hang during resume.
> >
> > [ KVM will have to disable/enable virtualization on the CPU itself that
> >   goes down / comes up, not via an IPI sent from the requesting CPU. ]
> >
> > Signed-off-by: Ingo Molnar <mingo@elte.hu>
> > ---
> >  drivers/kvm/kvm_main.c |    6 ------
> >  1 file changed, 6 deletions(-)
> >
> > Index: linux/drivers/kvm/kvm_main.c
> > ===================================================================
> > --- linux.orig/drivers/kvm/kvm_main.c
> > +++ linux/drivers/kvm/kvm_main.c
> > @@ -2083,12 +2083,6 @@ static int kvm_cpu_hotplug(struct notifi
> >  	case CPU_DEAD:
> >  	case CPU_UP_CANCELED:
> >  		decache_vcpus_on_cpu(cpu);
> > -		smp_call_function_single(cpu, kvm_arch_ops->hardware_disable,
> > -					 NULL, 0, 1);
> > -		break;
> > -	case CPU_UP_PREPARE:
> > -		smp_call_function_single(cpu, kvm_arch_ops->hardware_enable,
> > -					 NULL, 0, 1);
> >  		break;
> >  	}
> >  	return NOTIFY_OK;
> >   
> 
> That is already CPU_ONLINE in my tree
I noticed ;)
So this mean that Ingo's bug should already be fixed there.  And in rc2-mm1.
> (and in the pull request sent to 
> Linus a couple of days ago).
Resend, please.
Previous: Avi KivityNext: Ingo Molnar
Message 7 of 16 in “Re: 2.6.21-rc1: known regressions (part 2)”
  1. Ingo MolnarMar 2, 2007
  2. Ingo MolnarMar 2, 2007
  3. KVM: T60 resume fixIngo Molnar, Mar 2, 2007
  4. Michael S. TsirkinMar 2, 2007
  5. Avi KivityMar 3, 2007
  6. Avi KivityMar 3, 2007
  7. Andrew MortonMar 3, 2007
  8. Ingo MolnarMar 5, 2007
  9. Michael S. TsirkinMar 5, 2007
  10. Ingo MolnarMar 5, 2007
  11. Linus TorvaldsMar 2, 2007
  12. Ingo MolnarMar 5, 2007
  13. Michael S. TsirkinMar 5, 2007
  14. Michael S. TsirkinMar 5, 2007
  15. Ingo MolnarMar 5, 2007
  16. Jens AxboeMar 5, 2007

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.