Re: Problems installing as root

From: Shawn O. Pearce <spearce@spearce.org>
Date: Feb 25, 2007, 07:23 UTC
Message-ID: <20070225072330.GB1676@spearce.org>
In-Reply-To: <7vvehqvhcu.fsf@assigned-by-dhcp.cox.net>

Junio C Hamano <junkio@cox.net> wrote:

Show 6 quoted lines

> "Shawn O. Pearce" <spearce@spearce.org> writes:
> 
> > ..., and will
> > do the same in GIT-VERSION-GEN for git-gui.
> 
> I had an impression that GIT-VERSION-GEN in git-gui was Ok.

It is. I just looked at it to see about fixing it too and just realized what the `test $VN = $VC ||` chunk was all about. :-)

> > What about the top level GIT-VERSION-GEN in git.git?
> 
> I thought it is much more careful than git-gui/CREDITS-GEN about
> avoiding unnecessary rebuilding.

Yes, it is.  I didn't realize what it was doing until just now.  :-)

Apparently I'm missing the obvious tonight. There is a new version of git-gui now pushed out (1 commit, your patch). I did not bother to tag it. Please pull into maint.

-- 
Shawn.