Re: strange date generated by git-format-patch

From: Theodore Tso <tytso@mit.edu>
Date: Feb 24, 2007, 13:08 UTC
Message-ID: <20070224130839.GC4380@thunk.org>
In-Reply-To: <7vodnjzyvq.fsf@assigned-by-dhcp.cox.net>

On Sat, Feb 24, 2007 at 01:30:17AM -0800, Junio C Hamano wrote:

Show 12 quoted lines

> Johannes Schindelin <Johannes.Schindelin@gmx.de> writes:
> 
> >> That is just a fake random date to make the Unix-From line recognizable 
> >> by common MUA and does not have anything to do with your commit objects.
> >
> I do not think it is worth changing it.  Who's hurting with the
> current behaviour?  In other words, is it broken?  Unix-From
> lines are there only to separate each piece of e-mail in the
> mbox and otherwise is not used.  send-email, am, nor imap-send
> should care anything beyond the leading "From ", and mailsplit
> validates only that what's around the last colon near the end of
> line looks like time and year.

The only potential problem with it is that some MUA's (like mutt for example) sort by the From date by default. You can force it to list the patches in an unsorted order (via 'Ou'), but it might be nice if the patches date in the From field was the date that the patches were generated, with the seconds field bumped so that the patches in a series were guaranteed to have monotonically increasing dates. It's only a minor point, though.

						- Ted