Re: exception in git-gui when saving options

From: Shawn O. Pearce <spearce@spearce.org>
Date: Feb 18, 2007, 07:14 UTC
Message-ID: <20070218071457.GC31350@spearce.org>
In-Reply-To: <20070217194033.GH21842@admingilde.org>

Martin Waitz <tali@admingilde.org> wrote:

> I get the following backtrace when I want to save options in a
> git-gui which is started in blame mode:
> 
> The options seem to be saved correctly.

Whoops.  :-)  Its fixed with the following commit in git-gui:

commit 372ef954a15c321a1065bf7e764449ce7767277f
Author: Shawn O. Pearce <spearce@spearce.org>
Date:   Sun Feb 18 02:12:32 2007 -0500

    git-gui: Correct crash when saving options in blame mode.
    
    Martin Waitz noticed that git-gui crashed while saving the user's
    options out if the application was started in blame mode.  This
    was caused by the do_save_config procedure invoking reshow_diff
    incase the number of context lines was modified by the user.
    Because we bypassed main window UI setup to enter blame mode we
    did not set many of the globals which were accessed by reshow_diff,
    and reading unset variables is an error in Tcl.
    
    Aside from moving the globals to be set earlier, I also modified
    reshow_diff to not invoke clear_diff if there is no path currently
    in the diff viewer.  This way reshow_diff does not crash when in
    blame mode due to the $ui_diff command not being defined.
    
    Signed-off-by: Shawn O. Pearce <spearce@spearce.org>

-- 
Shawn.