Re: [PATCH] Support for large files on 32bit systems.

From: Shawn O. Pearce <spearce@spearce.org>
Date: Feb 17, 2007, 09:49 UTC
Message-ID: <20070217094959.GH27864@spearce.org>
In-Reply-To: <20070217093953.GE21842@admingilde.org>

Martin Waitz <tali@admingilde.org> wrote:

Show 7 quoted lines

> arg, this patch is completely broken.
> I tested it by setting the macro via the command line and the
> = is still left in there.  And __GLIBC__ is not yet defined at this
> point.
> 
> However, we need to set _FILE_OFFSET_BITS for glibc somehow.
> What is the best way to do so?

I think the only way to do with this is to have the Makefile detect if -D_FILE_OFFSET_BITS=64 is required to be added to CFLAGS based on some rule (e.g. uname output?), then add that to CFLAGS when needed.

This is one area where autoconf is nice, as you can compile a thousand little C programs to see how the compiler reacts by default, and when you attempt to set this define, and then decide if you should include it or not.

It is also the part of autoconf that's not-so-nice... as it compiles a thousand little C programs just to figure out how to compile the real program. ;-)

-- 
Shawn.