Re: Why a _full_ diff? (was: [PATCH] Char: serial167, cleanup (fwd))

From: Jeff King <peff@peff.net>
Date: Feb 12, 2007, 09:20 UTC
Message-ID: <20070212092028.GB12605@coredump.intra.peff.net>
In-Reply-To: <Pine.LNX.4.62.0702120934120.10436@chinchilla.sonytel.be>

On Mon, Feb 12, 2007 at 09:39:46AM +0100, Geert Uytterhoeven wrote:

> I received the email below, showing a _full_ (i.e. every single line) diff
> between the old and the new version:

Hmm. I'm not sure what is generating this, but the diffstat in the email is wrong (anybody know where the mailing list feeder script lives?).

Show 9 quoted lines

> | diff --git a/drivers/char/serial167.c b/drivers/char/serial167.c
> | dissimilarity index 67%
> | index af50d32..5fd314a 100644
> | --- a/drivers/char/serial167.c
> | +++ b/drivers/char/serial167.c
> | @@ -1,2824 +1,2792 @@
> | -/*
> | - * linux/drivers/char/serial167.c
> | - *

This may or may not be related to the diffstat issue; you can get a similar effect by asking for a lot of context. For example:

  git show --unified=150 44bafd

> | anakin$ git show 44bafdf37b30234671d4e2fb595dea4c3717d089 | diffstat
> |  serial167.c | 3322 +++++++++++++++++++++++++++++-------------------------------
> |  1 file changed, 1645 insertions(+), 1677 deletions(-)

This is also what git produces, using

  git show --stat 44bafd

I think there is probably some erroneous magic going on in whatever script generates the mail.

-Peff