Re: [PATCH 1/2] Don't leak file descriptors from unavailable pack files.

From: Shawn O. Pearce <spearce@spearce.org>
Date: Feb 2, 2007, 08:53 UTC
Message-ID: <20070202085343.GD20832@spearce.org>
In-Reply-To: <7vbqkdhs4d.fsf@assigned-by-dhcp.cox.net>

Junio C Hamano <junkio@cox.net> wrote:

Show 6 quoted lines

> I agree leaking fd is not nice, but I wonder if that should be
> dealt with by the caller.
> 
> Originally it did not matter as open_packed_git() died, but
> shouldn't it be closing the fd and marking p->pack_fd with -1, as
> you made it return instead of die?

Yea, I thought of that when I wrote that evil patch...

But open_packed_git has 12 things that can cause it to return an error. That's basically a rewrite of the function. This was 4 lines added to the only caller which didn't die().

Probably the wrong thing to do.  But the patch was shorter!

Do you want to reject this patch and have me rewrite open_packed_git instead?

-- 
Shawn.