git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: git-blame.el

From
Karl Hasselström <kha@treskal.com>
Date
Feb 1, 2007, 13:12 UTC
Message-ID
<20070201131213.GB11611@diana.vm.bytemark.co.uk>
In-Reply-To
<87iren2vqx.fsf@morpheus.local>
On 2007-01-31 14:04:06 +0100, David Kågedal wrote:
> Here's another version of git-blame.el that automatically tries to
> create a sensible list of colors to use for both light and dark
> backgrounds. Plus a few minor fixes.

I've tried it, like the concept of in-buffer blame and the pretty colors, and have a few comments and suggestions:

  1. For some files, but not all, emacs is unresponsive (and consumes
     lots of CPU) right after git-blame-mode is activated. Once
     git-blame has finished, it becomes responsive again, but this
     kind of defeats the whole "incremental" idea.
     This is most easily seen by holdnig down Ctrl+N or similar, to
     make the cursor move constantly.
  2. Getting to see the sha1 of the commit is not so useful when it
     can't be selected for copy-pasting. Maybe a keyboard shortcut for
     "copy-sha1-to-kill-ring"?
  3. Even after I've edited a line, or added a new line, they continue
     to be attributed to the same existing commits. They should either
     have no attribution, or possibly just "local edit" or something.
     I seem to recall this kind of functionality for git-blame being
     discussed very recently?
  4. It would be nice with a keyboard shortcut that (in a new buffer)
     printed more details about the commit under the cursor, kind of
     like the output from git-log. (Having this available would
     obviate the need for (2).)
  5. It would be nice with a keyboard shortcut for displaying the
     commit under the cursor in gitk. (For extra points: successive
     uses of this command should reuse the same gitk window if it's
     still open.)
  6. It would be nice with a keyboard shortcut for displaying (in a
     separate buffer) the diff to that file introduced by the commit
     under the cursor. This could be combined with (3) by having
     commit details followed by diff.
Oh, and try to have it done by Monday. ;-)
-- 
Karl Hasselström, kha@treskal.com
      www.treskal.com/kalle
Previous: David KågedalNext: David Kågedal
Message 6 of 9 in “git-blame.el”
  1. David KågedalJan 31, 2007
  2. Randal L. SchwartzJan 31, 2007
  3. David KågedalJan 31, 2007
  4. Junio C HamanoJan 31, 2007
  5. David KågedalJan 31, 2007
  6. Karl HasselströmFeb 1, 2007
  7. David KågedalFeb 1, 2007
  8. Karl HasselströmFeb 1, 2007
  9. git-blame.el --- Minor mode for incremental blame for GitJakub Narebski, Feb 4, 2007

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.