Re: [PATCH] Add new 'rebase' command.

From: Yann Dirson <ydirson@altern.org>
Date: Jan 21, 2007, 23:26 UTC
Message-ID: <20070121232618.GD4665@nan92-1-81-57-214-146.fbx.proxad.net>
In-Reply-To: <b0943d9e0701211500v2f54aa61k2592ba060131318@mail.gmail.com>

On Sun, Jan 21, 2007 at 11:00:57PM +0000, Catalin Marinas wrote:

Show 10 quoted lines

> On 20/01/07, Yann Dirson <ydirson@altern.org> wrote:
> >Take two: I had forgotten to add "rebase" to the list of stack
> >commands for the purpose of help.
> 
> Thanks for the patch. I also added the command to the stgit-completion.bash.
> 
> I applied it but changed the patch a bit so that there is no need for
> the --to option. I understood your point but I find it a bit strange
> to have this mandatory option. Anyway, command line syntax doesn't
> have to follow the natural language exactly :-).

Well, I thought the natural next patch to this command would be, according to the discussions with Jakub, to make first "--to target" optional, as a natural replacement for "stg pull . <target>" when the target is the parent branch, and then possibly add the ability of running rebase from the target branch as also sugested by Jakub, leading to the natural "rebase [<stack>|--to <target>]" syntax.

Although I'm not sure we'll do that in the near future, removing the need for --to would somewhat get in the way of this possibility.

Best regards,

-- 
Yann.