Re: SEGV in git-apply

From: Martin Waitz <tali@admingilde.org>
Date: Jan 20, 2007, 18:36 UTC
Message-ID: <20070120183615.GA6459@admingilde.org>
In-Reply-To: <Pine.LNX.4.63.0701200312000.22628@wbgn013.biozentrum.uni-wuerzburg.de>

hoi :)

On Sat, Jan 20, 2007 at 03:14:46AM +0100, Johannes Schindelin wrote:

> But without that patch I cannot tell.

patch was this one:

------------------ 8< ------------------------------- --- src/callbacks.cc 2006-11-02 10:16:50.000000000 +0100 +++ src/callbacks.cc 2007-01-17 20:47:00.000000000 +0100

@@ -12890,12 +12890,11 @@ void on_unknown_edit_optionmenu_sign_cha
 	}
 }
 
-gboolean on_key_press_event(GtkWidget*, GdkEventKey *event, gpointer) {
+gboolean on_key_press_event(GtkWidget *o, GdkEventKey *event, gpointer) {
 	if(!GTK_WIDGET_HAS_FOCUS(expression) && (event->keyval > GDK_Hyper_R || event->keyval < GDK_Shift_L)) {
-		bool return_val = FALSE;
 		GtkWidget *w = gtk_window_get_focus(GTK_WINDOW(glade_xml_get_widget (main_glade, "main_window")));
-		if(w) g_signal_emit_by_name((gpointer) w, "key_press_event", event, &return_val);
-		if(return_val) return TRUE;
+		if(gtk_bindings_activate_event(GTK_OBJECT(o), event)) return TRUE;
+		if(w && gtk_bindings_activate_event(GTK_OBJECT(w), event)) return TRUE;
 		focus_keeping_selection();
 	}
 	return FALSE;
------------------ 8< -------------------------------

git-apply inside the "src" directory segfaulted.

-- 
Martin Waitz