git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[PATCH] New files in git weren't being downloaded during CVS update

From
APAndy Parkins <andyparkins@gmail.com>
Date
Jan 19, 2007, 10:49 UTC
Message-ID
<200701191049.40833.andyparkins@gmail.com>

If a repository was checked out via git-cvsserver and then later a new file is added to the git repository via some other method; a CVS update wasn't fetching the new file.

It would be reported as a new file as
 A some/dir/newfile.c
but would never appear in the directory.

The problem (I think) is that when git-cvsserver detected a new file, it was issuing the new file message then skipping the actual file send part and moving to the next file its list. In fact only an updated file would be transmitted.

The fix is to simply remove the "next" that was skipping the file transmit; which is what this patch does.

Signed-off-by: Andy Parkins <andyparkins@gmail.com>
---
I don't understand enough about the CVS protocol to know whether this really
is the right fix.  It certainly addresses my problem, but I assume that the "next"
was put in there for a reason.
 git-cvsserver.perl |    1 -
 1 files changed, 0 insertions(+), 1 deletions(-)
diff --git a/git-cvsserver.perl b/git-cvsserver.perl
index a33a876..c370a53 100755
--- a/git-cvsserver.perl
+++ b/git-cvsserver.perl
@@ -882,7 +882,6 @@ sub req_update
 		print "MT text A \n";
                 print "MT fname $filename\n";
                 print "MT newline\n";
-		next;
 
 	    }
 	    else {
-- 
1.5.0.rc1.gf4b6c
Next: Simon 'corecode' Schubert
Message 1 of 4 in “New files in git weren't being downloaded during CVS update”
  1. New files in git weren't being downloaded during CVS updateAndy Parkins, Jan 19, 2007
  2. Simon 'corecode' SchubertJan 20, 2007
  3. Andy ParkinsJan 20, 2007
  4. Simon 'corecode' SchubertJan 20, 2007

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.