Re: [PATCH 2/4] Hash tags by commit SHA1 in git-describe.
- From
Shawn O. Pearce <spearce@spearce.org>
- Date
- Jan 14, 2007, 23:19 UTC
- Message-ID
- <20070114231937.GF10888@spearce.org>
- In-Reply-To
- <7vr6txh278.fsf@assigned-by-dhcp.cox.net>
Junio C Hamano <junkio@cox.net> wrote:
Show 14 quoted lines
> Johannes Schindelin <Johannes.Schindelin@gmx.de> writes: > > > On Sat, 13 Jan 2007, Shawn O. Pearce wrote: > > > >> If a project has a very large number of tags then git-describe > >> will spend a good part of its time looping over the tags testing > >> them one at a time to determine if it matches a given commit. > > > > Why not just use object_refs? This also obviates the need for your patch > > 3/4, since you no longer have buckets to search binarily. Plus, it uses a > > hash map, which already turned out to beat (in terms of performance) the > > hell out of bucketed lists in git history. > > Very good point.
OK. I didn't realize we had a better system already implemented. Thanks for pointing it out.
I'll work up a patch to replace the crude hash/list arrangement with something based on object_refs instead.
-- Shawn.