git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH 1/4] Remove unnecessary call_depth parameter in merge-recursive.

From
Shawn O. Pearce <spearce@spearce.org>
Date
Jan 14, 2007, 22:44 UTC
Message-ID
<20070114224457.GB10888@spearce.org>
In-Reply-To
<20070114193503.GB2378@steel.home>
Alex Riesen <fork0@t-online.de> wrote:
Show 6 quoted lines
> Shawn O. Pearce, Sun, Jan 14, 2007 06:28:33 +0100:
> > Because the output_indent always matches the call_depth value
> > there is no reason to pass around the call_depth to the merge
> > function during each recursive invocation.
> 
> Actually, you removed output_indent, not call_depth.

Yeaaaaa. That happened because I amended the commit. The first version of it kept output_indent and replaced all call_depth with output_indent. I was then going to do another patch to rename output_indent -> call_depth, but I noticed the patch would be about the same size as that one and would affect the same lines, so I just amended it. Then I didn't edit the commit message.

-- 
Shawn.
Previous: Alex Riesen
Message 3 of 3 in “Remove unnecessary call_depth parameter in merge-recursive.”
  1. 1/4 Remove unnecessary call_depth parameter in merge-recursive.Shawn O. Pearce, Jan 14, 2007
  2. Alex RiesenJan 14, 2007
  3. Shawn O. PearceJan 14, 2007

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.