Re: [BUG] stgit: unexpected "unknown user details" on refresh

From: Yann Dirson <ydirson@altern.org>
Date: Jan 5, 2007, 22:29 UTC
Message-ID: <20070105222944.GA6179@nan92-1-81-57-214-146.fbx.proxad.net>
In-Reply-To: <b0943d9e0701050107s21ec8527ud89425df4772998@mail.gmail.com>

On Fri, Jan 05, 2007 at 09:07:51AM +0000, Catalin Marinas wrote:

> It probably tries to set the author information for the patch and
> GIT_AUTH* or GIT_COMMIT* aren't set but it would be probably useful to
> get the full backtrace of this error (at the end of the stgit/main.py
> file, just add a "raise" before sys.exit(2)).

Email vars are set, name is taken (by git) from GECOS. Apparently StGIT does not use the latter. It would surely be more user-friendly to use it, as much for providing a (hopefully) sane default as to get a behaviour consistent with GIT.

$ env|grep GIT GIT_COMMITTER_EMAIL=ydirson@altern.org GIT_AUTHOR_EMAIL=ydirson@altern.org

As you expected:

Traceback (most recent call last):
  File "./stg", line 43, in ?
    main()
  File "/export/work/yann/git/stgit/stgit/main.py", line 262, in main
    command.func(parser, options, args)
  File "/export/work/yann/git/stgit/stgit/commands/refresh.py", line 145, in func
    backup = True, sign_str = sign_str)
  File "/export/work/yann/git/stgit/stgit/stack.py", line 674, in refresh_patch
    patch.set_authdate(author_date)
  File "/export/work/yann/git/stgit/stgit/stack.py", line 265, in set_authdate
    self._set_field('authdate', date or git.author().date)
  File "/export/work/yann/git/stgit/stgit/git.py", line 475, in author
    __author = user()
  File "/export/work/yann/git/stgit/stgit/git.py", line 457, in user
    raise GitException, 'unknown user details'
stgit.git.GitException: unknown user details

Best regards,

-- 
Yann.