Re: [PATCH 1/2] Teach git-reset to let others override its reflog entry.

From: Shawn Pearce <spearce@spearce.org>
Date: Dec 28, 2006, 06:22 UTC
Message-ID: <20061228062233.GA17304@spearce.org>
In-Reply-To: <7vslf0zgwp.fsf@assigned-by-dhcp.cox.net>

Junio C Hamano <junkio@cox.net> wrote:

Show 8 quoted lines

> "Shawn O. Pearce" <spearce@spearce.org> writes:
> 
> > The new --reflog-action for git-reset behaves like the same option
> > to git-merge; it can be used by the caller to override the message
> > entry in the reflog and is intended to be used only when git-reset
> > is acting as plumbing, not porcelain.
> 
> Honestly, I hate these --reflog-action options everywhere.

Me too.  Yet I submit patches to add them.  ;-)

> Then calls to "git-update-ref -m" could use the value of
> "$GIT_REFLOG_ACTION", without explicit --reflog-action=
> parameters and $rloga variables.

I agree.  Your suggestion is way more elegant.

I have some more git-am/git-merge/git-pull/git-rebase patches brewing; I'm finishing the commit message for the last in the sequence. I'll update it to include your suggestion and try to start cleaning up this --reflog-action mess, then ship the series out to the list, including this mini 2 patch series you are rejecting for good reason.

-- 
Shawn.