Re: [RFC/PATCH 6/6] gitweb: Make possible to run under mod_perl without ParseHeaders

From: Jakub Narebski <jnareb@gmail.com>
Date: Dec 28, 2006, 01:12 UTC
Message-ID: <200612280212.45120.jnareb@gmail.com>
In-Reply-To: <20061228010311.GD6558@localhost>

Robert Fitzsimons wrote:

Show 12 quoted lines

>> @@ -1854,7 +1976,8 @@ EOF
>>  		      $cgi->hidden(-name => "a") . "\n" .
>>  		      $cgi->hidden(-name => "h") . "\n" .
>>  		      $cgi->popup_menu(-name => 'st', -default => 'commit',
>> -				       -values => ['commit', 'author', 'committer', 'pickaxe']) .
>> +		                       -values => ['commit', 'author', 'committer',
>> +		                       gitweb_check_feature('pickaxe') ? 'pickaxe' : ()]) .
>>  		      $cgi->sup($cgi->a({-href => href(action=>"search_help")}, "?")) .
>>  		      " search:\n",
>>  		      $cgi->textfield(-name => "s", -value => $searchtext) . "\n" .
> 
> This should be a separate patch.

I'm sorry, somehow I missed this.

Besides, it would be better to assign return value to some variable, to avoid calling gitweb_check_feature again...

-- 
Jakub Narebski
Poland