Re: [PATCH] Enable reflogs by default in any repository with a working directory.
- From
Shawn Pearce <spearce@spearce.org>
- Date
- Dec 15, 2006, 00:20 UTC
- Message-ID
- <20061215002015.GI26202@spearce.org>
- In-Reply-To
- <Pine.LNX.4.63.0612150112010.3635@wbgn013.biozentrum.uni-wuerzburg.de>
Johannes Schindelin <Johannes.Schindelin@gmx.de> wrote:
Show 14 quoted lines
> Hi,
>
> On Thu, 14 Dec 2006, Shawn O. Pearce wrote:
>
> > +int is_bare_git_dir (const char *dir)
> > +{
> > + if (!strcmp(dir, DEFAULT_GIT_DIR_ENVIRONMENT))
> > + return 0;
> > + const char *s = strrchr(dir, '/');
> > + return !s || strcmp(s + 1, DEFAULT_GIT_DIR_ENVIRONMENT);
> > }
>
> This function does not really determine if the repo is bare. I have no
> better name for it, though.guess_if_bare_git_dir ?
I struggled to name that thing because it can't really tell, its just guessing... but it is going to be right most of the time. Of course I'm sure there's some Git user somewhere who will confuse it.