Re: [PATCH 5/5] git-svn: re-map repository URLs and UUIDs on SVK mirror paths
- From
- Eric Wong <normalperson@yhbt.net>
- Date
- Dec 5, 2006, 08:58 UTC
- Message-ID
- <20061205085804.GB27236@soma>
- In-Reply-To
- <20061205051738.16552.22494.stgit@localhost>
Sam Vilain <sam@vilain.net> wrote:
Show 8 quoted lines
> From: Sam Vilain <sam@vilain.net> > > If an SVN revision has a property, "svm:headrev", it is likely that > the revision was created by "svk sync". The property contains a > repository UUID and a revision. We want to make it look like we are > mirroring the original URL, so introduce a helper function that > returns the original identity trio, and use it when generating commit > messages and dummy e-mail domains.
Upon further review, this would make 'git svn rebuild' behave unexpectedly (it would make the git-svn metadata, including .rev_db entries point to the original repo and not the SVK one). This may not necessarily be a big deal, however.
Also, incremental fetches (or fetching more than 1k sequential revisions) would probably fail. To fix this, read the offset of last entry in .rev_db instead of git-svn-id: from the last commit to get the last revision. But since rebuild won't work as expected; losing the .rev_db file means you wouldn't be able to fetch from the SVK repo anymore (but the original upstream one will be fine).
One last thing: feature should be made optional. I actually work day-to-day on a repository that was created with svm/SVN::Mirror, the original repository no longer exists; but the mirrored one still has these properties (I suppose I could remove the props server-side, but some people may not have the permissions).