git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[PATCH] gitweb: Fix Atom feed <logo>: it is $logo, not $logo_url

From
Jakub Narebski <jnareb@gmail.com>
Date
Dec 4, 2006, 13:09 UTC
Message-ID
<200612041409.43543.jnareb@gmail.com>

Fix contents of Atom feed <logo> element; it should be URL of $logo, not URL pointed by logo link.

Signed-off-by: Jakub Narebski <jnareb@gmail.com>
---
Do anyone use Atom feed logo? This error was from the beginning of Atom
feed generation in git.git version of gitweb, and nobody complained.
I wonder why it is <logo>URL</logo>, and not <logo href="URL" />...
 gitweb/gitweb.perl |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/gitweb/gitweb.perl b/gitweb/gitweb.perl
index 093bd72..ffe8ce1 100755
--- a/gitweb/gitweb.perl
+++ b/gitweb/gitweb.perl
@@ -4282,7 +4282,7 @@ XML
 		}
 		if (defined $logo_url) {
 			# not twice as wide as tall: 72 x 27 pixels
-			print "<logo>" . esc_url($logo_url) . "</logo>\n";
+			print "<logo>" . esc_url($logo) . "</logo>\n";
 		}
 		if (! %latest_date) {
 			# dummy date to keep the feed valid until commits trickle in:
-- 
1.4.4.1
Message 1 of 1 in “gitweb: Fix Atom feed <logo>: it is $logo, not $logo_url”
  1. gitweb: Fix Atom feed <logo>: it is $logo, not $logo_urlJakub Narebski, Dec 4, 2006

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.