Re: [EGIT PATCH] Convert author and comment on demand.

From: Robin Rosenberg <robin.rosenberg@dewire.com>
Date: Dec 3, 2006, 12:18 UTC
Message-ID: <200612031318.33332.robin.rosenberg@dewire.com>
In-Reply-To: <20061203021655.GA26668@spearce.org>

söndag 03 december 2006 03:16 skrev Shawn Pearce:

Show 13 quoted lines

> Robin Rosenberg <robin.rosenberg@dewire.com> wrote:
> > This sppeds up reading commits a lot by only store the byte
> > array data when reading commits.
>
> Thanks.  I was working on something similar but did not have
> a chance to finish it.  I've applied your patch instead.
>
> > +	    try {
> > +        	BufferedReader br=new BufferedReader(new InputStreamReader(new
> > ByteArrayInputStream(raw)));
> > +        	String n=br.readLine();
>
> Something's wrong with your mail client... the patch was mangled.

Not really, only the user. KMail by default wraps lines and I didn't turn that off before sending. Usually I send patches just using stg mail, but this time I used git-format-patch and kmail. Generatig attachements may be better (next time).