Re: EGIT unpackedreadr problem

From: Shawn Pearce <spearce@spearce.org>
Date: Dec 3, 2006, 02:25 UTC
Message-ID: <20061203022513.GB26668@spearce.org>
In-Reply-To: <200612030200.13857.robin.rosenberg@dewire.com>

Robin Rosenberg <robin.rosenberg@dewire.com> wrote:

> Subject: [PATCH] Utility to show a log.

Thanks.  This is somewhat handy so I've applied the utility program.

Like your other patch to Commit class this one had some whitespace
issues.  In the future could you apply the Eclipse formatter (using
the Java Conventions style) to the source before genererating a diff?

> Not sure what's going on. The  UnpackedReader "looks" like it does
> the equivalent of what it did before,but apparently it isn't.

Yea... I broke the legacy header parsing in 42691339. The breakage actually showed up in one of the unit tests (test009_CreateCommitOldFormat) but I didn't notice it before pushing the changes out as I failed to run the entire unit test suite first. Whoops.

I found it and fixed it in f70704f9. The issue was we were copying the remaining data from the Inflater ontop of the data we had already decompressed out for the header; this meant that we lost the leading bytes of each object. I just neglated to push the fix out. Double whoops.