Re: [PATCH 12/10] Teach bash about git-repo-config.

From: Shawn Pearce <spearce@spearce.org>
Date: Nov 28, 2006, 07:53 UTC
Message-ID: <20061128075325.GB9056@spearce.org>
In-Reply-To: <7vodqscqty.fsf@assigned-by-dhcp.cox.net>

Junio C Hamano <junkio@cox.net> wrote:

Show 11 quoted lines

> "Shawn O. Pearce" <spearce@spearce.org> writes:
> 
> >  Yes, that's it.  I'm finally done tinkering with bash
> >  completion support for this week.  Total of 12 patches.
> 
> Thanks.  I saw a funky behaviour when I tried this:
> 
> 	$ git pull . ap<TAB>
> 
> ==>
> 	$ git pull . apfatal: Not a git repository: '.'

Doh. Its the commit titled "Support bash completion of refs/remote". The problem is I'm invoking git-for-each-ref wrong:

	git --git-dir=. for-each-ref ...

Clearly "." isn't a git directory. But ./.git is. The breakage is the switch from git-peek-remote to git-for-each-ref. git-peek-remote nicely realized that "." wasn't a git directory but "./.git" was and went into ./.git to get the refs. I switched to for-each-ref to get a potential speed boost (no need to dereference tags) but broke the damn thing in the process.

I thought I had tested this for-each-ref change out. Apparently I missed a case.

I'll fix it tomorrow.